Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic port changing #511

Closed
wants to merge 11 commits into from
Closed

Dynamic port changing #511

wants to merge 11 commits into from

Conversation

InternetExplorer7
Copy link
Contributor

@InternetExplorer7 InternetExplorer7 commented Mar 19, 2018

CLOSED, please refer to #516

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 19, 2018
@JoelMarcey
Copy link
Contributor

@InternetExplorer7 Thanks for breaking these out. However, it looks like there is some stuff left over from the other commits in this PR. As well as changes to package.json, etc. files as well.

I think the only 3 files needed for this PR are: README.md, start-server.js and server.js. Not the other 4 files.

There are also similar things in the other two PRs as well.

@InternetExplorer7
Copy link
Contributor Author

Got it. I will fix this in a few moments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants